| Message ID | 20220825012401.2753758-1-alex.hung@amd.com |
|---|---|
| State | Accepted |
| Commit | 79ebd88d01d679ffe9f6f24108c6ac4dc3f04ddd |
| Headers | show |
| Series |
"tests/kms_concurrent: remove an AMD device check"
( rev:
1
)
in
IGT |
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index 6f8ffd4a..3ad51569 100644 --- a/tests/kms_concurrent.c +++ b/tests/kms_concurrent.c @@ -276,8 +276,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou /* switch to lower resolution */ igt_output_override_mode(output, mode_lo); free(mode_lo); - if (is_amdgpu_device(data->drm_fd)) - igt_output_set_pipe(output, PIPE_NONE); igt_display_commit2(&data->display, COMMIT_ATOMIC); /* switch back to higher resolution */
On Thu, Aug 25, 2022 at 3:54 AM Alex Hung <alex.hung@amd.com> wrote: > > This is to be deprecated by a kernel fix. Can you link the kernel commit for reference > > Signed-off-by: Alex Hung <alex.hung@amd.com> > --- > tests/kms_concurrent.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c > index 6f8ffd4a..3ad51569 100644 > --- a/tests/kms_concurrent.c > +++ b/tests/kms_concurrent.c > @@ -276,8 +276,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou > /* switch to lower resolution */ > igt_output_override_mode(output, mode_lo); > free(mode_lo); > - if (is_amdgpu_device(data->drm_fd)) > - igt_output_set_pipe(output, PIPE_NONE); > igt_display_commit2(&data->display, COMMIT_ATOMIC); > > /* switch back to higher resolution */ > -- > 2.37.2 >
On 2022-08-25 08:37, Mark Yacoub wrote: > On Thu, Aug 25, 2022 at 3:54 AM Alex Hung <alex.hung@amd.com> wrote: >> >> This is to be deprecated by a kernel fix. > Can you link the kernel commit for reference The kernel and IGT patches are inter-dependent. This patch is required to avoid regression from kernel testing and that's the reason I submitted IGT patch first. >> >> Signed-off-by: Alex Hung <alex.hung@amd.com> >> --- >> tests/kms_concurrent.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c >> index 6f8ffd4a..3ad51569 100644 >> --- a/tests/kms_concurrent.c >> +++ b/tests/kms_concurrent.c >> @@ -276,8 +276,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou >> /* switch to lower resolution */ >> igt_output_override_mode(output, mode_lo); >> free(mode_lo); >> - if (is_amdgpu_device(data->drm_fd)) >> - igt_output_set_pipe(output, PIPE_NONE); >> igt_display_commit2(&data->display, COMMIT_ATOMIC); >> >> /* switch back to higher resolution */ >> -- >> 2.37.2 >>
On Thu, Aug 25, 2022 at 2:21 PM Alex Hung <alex.hung@amd.com> wrote: > > > > On 2022-08-25 08:37, Mark Yacoub wrote: > > On Thu, Aug 25, 2022 at 3:54 AM Alex Hung <alex.hung@amd.com> wrote: > >> > >> This is to be deprecated by a kernel fix. > > Can you link the kernel commit for reference > > The kernel and IGT patches are inter-dependent. This patch is required > to avoid regression from kernel testing and that's the reason I > submitted IGT patch first. sounds good. Always good removing driver specific checks. > > >> > >> Signed-off-by: Alex Hung <alex.hung@amd.com> Reviewed-by: Mark Yacoub <markyacoub@chromium.org> > >> --- > >> tests/kms_concurrent.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c > >> index 6f8ffd4a..3ad51569 100644 > >> --- a/tests/kms_concurrent.c > >> +++ b/tests/kms_concurrent.c > >> @@ -276,8 +276,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou > >> /* switch to lower resolution */ > >> igt_output_override_mode(output, mode_lo); > >> free(mode_lo); > >> - if (is_amdgpu_device(data->drm_fd)) > >> - igt_output_set_pipe(output, PIPE_NONE); > >> igt_display_commit2(&data->display, COMMIT_ATOMIC); > >> > >> /* switch back to higher resolution */ > >> -- > >> 2.37.2 > >>
This is to be deprecated by a kernel fix. Signed-off-by: Alex Hung <alex.hung@amd.com> --- tests/kms_concurrent.c | 2 -- 1 file changed, 2 deletions(-)