From: Nathan Chancellor <nathan@kernel.org>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: Vijendar.Mukunda@amd.com, Syed.SabaKareem@amd.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs()
Date: Thu, 05 Jan 2023 08:53:32 -0700 [thread overview]
Message-ID: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org> (raw)
Clang warns:
sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here
return ret;
^~~
sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 error generated.
Return -ENODEV, which matches the debug message's description of this block.
Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic")
Link: https://github.com/ClangBuiltLinux/linux/issues/1779
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
sound/soc/amd/ps/pci-ps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 401cfd0036be..f54b9fd9c3ce 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -217,6 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data
break;
default:
dev_dbg(&pci->dev, "No PDM devices found\n");
+ ret = -ENODEV;
goto de_init;
}
---
base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46
change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Syed.SabaKareem@amd.com, Vijendar.Mukunda@amd.com
Subject: [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs()
Date: Thu, 05 Jan 2023 08:53:32 -0700 [thread overview]
Message-ID: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org> (raw)
Clang warns:
sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here
return ret;
^~~
sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 error generated.
Return -ENODEV, which matches the debug message's description of this block.
Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic")
Link: https://github.com/ClangBuiltLinux/linux/issues/1779
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
sound/soc/amd/ps/pci-ps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 401cfd0036be..f54b9fd9c3ce 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -217,6 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data
break;
default:
dev_dbg(&pci->dev, "No PDM devices found\n");
+ ret = -ENODEV;
goto de_init;
}
---
base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46
change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
next reply other threads:[~2023-01-05 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 15:53 Nathan Chancellor [this message]
2023-01-05 15:53 ` [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs() Nathan Chancellor
2023-01-05 17:04 ` Mukunda,Vijendar
2023-01-05 17:04 ` Mukunda,Vijendar
2023-01-05 17:11 ` [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs()m Nathan Chancellor
2023-01-05 17:11 ` Nathan Chancellor
2023-01-05 17:34 ` [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs() Nathan Chancellor
2023-01-05 17:34 ` Nathan Chancellor
2023-01-05 23:39 ` Mukunda,Vijendar
2023-01-05 23:39 ` Mukunda,Vijendar
2023-01-09 16:49 ` Mark Brown
2023-01-09 16:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org \
--to=nathan@kernel.org \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.