From: "Christian König" <christian.koenig@amd.com>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA
Date: Tue, 19 Apr 2022 16:07:44 +0200 [thread overview]
Message-ID: <20bac605-97e6-e5cd-c4e4-83a8121645d8@amd.com> (raw)
In-Reply-To: <20220419135908.39606-3-cai.huoqing@linux.dev>
Am 19.04.22 um 15:59 schrieb Cai Huoqing:
> The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP
> which is integrated into NVIDIA Jetson AGX Xavier,
> so add driver support for this accelerator.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
>
Well doesn't looks so bad on first glance (regarding coding style etc..)
But am I blind or isn't there any UAPI for the driver? I mean adding a
DRM driver without any change to include/uapi/drm is really odd.
Regards,
Christian.
next prev parent reply other threads:[~2022-04-19 14:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 13:58 [PATCH 0/2] drm/nvdla: Add driver support for NVDLA Cai Huoqing
2022-04-19 13:58 ` [PATCH 1/2] MAINTAINERS: Add the driver info of the NVDLA Cai Huoqing
2022-04-19 13:59 ` [PATCH 2/2] drm/nvdla: Add driver support for NVDLA Cai Huoqing
2022-04-19 14:07 ` Christian König [this message]
2022-04-19 14:35 ` Cai Huoqing
2022-04-20 7:53 ` kernel test robot
2022-04-20 9:57 ` kernel test robot
2022-04-20 10:26 ` Thomas Zimmermann
2022-04-21 8:09 ` Cai Huoqing
2022-04-21 8:30 ` Thomas Zimmermann
2022-04-21 8:34 ` Christian König
2022-04-21 8:57 ` Thomas Zimmermann
2022-04-21 9:07 ` Thomas Zimmermann
2022-04-21 9:13 ` Thomas Zimmermann
2022-04-21 9:23 ` Christian König
2022-04-21 22:01 ` Kari Argillander
2022-04-25 14:28 ` Cai Huoqing
2022-04-27 15:23 ` Daniel Vetter
2022-04-26 5:20 ` [PATCH 0/2] " Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20bac605-97e6-e5cd-c4e4-83a8121645d8@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=cai.huoqing@linux.dev \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).