From: Huang Rui <ray.huang@amd.com>
To: Stefano Picascia <stefano.picascia@insiberia.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Allow selecting amd-pstate without CPU_SUP_INTEL
Date: Tue, 9 Nov 2021 22:19:49 +0800 [thread overview]
Message-ID: <YYqDhaXDIqJyjGjg@hr-amd> (raw)
In-Reply-To: <6b30aaf57cec5b6a72cff1f32d4fe24e47e9754b.camel@insiberia.net>
O Mon, Nov 08, 2021 at 06:01:51PM +0800, Stefano Picascia wrote:
> On Mon, 2021-11-08 at 17:13 +0800, Huang Rui wrote:
> > On Sat, Nov 06, 2021 at 07:55:29PM +0800, Stefano Picascia wrote:
> > > Currently, even if selected, amd-pstate is not enabled unless
> > > CPU_SUP_INTEL is also selected, due to ACPI_CPPC_LIB depending on
> > > SCHED_MC_PRIO, which in turn depends on CPU_SUP_INTEL
> >
> > Actually, amd-pstate driver doesn't depend on SCHED_MC_PRIO.
>
> amd-pstate doesn't depend on SCHED_MC_PRIO, but ACPI_CPPC_LIB is only
> selected when SCHED_MC_PRIO is selected. I guess the issue can be fixed
> in a better way, but currently if one compiles the kernel with
> CPU_SUP_AMD, but without CPU_SUP_INTEL, ends up with a non functional
> amd-pstate.
>
> Not a problem for distro kernels I guess, but I was puzzled as I wasn't
> getting amd-pstate even with a supported processor.
>
If I modify the Kconfig of amd-pstate like below:
config X86_AMD_PSTATE
bool "AMD Processor P-State driver"
depends on X86
select ACPI_PROCESSOR if ACPI
select ACPI_CPPC_LIB if X86_64 && ACPI
select CPU_FREQ_GOV_SCHEDUTIL if SMP
Then ACPI_CPPC_LIB can be selected by X86_AMD_PSTATE as well:
Symbol: ACPI_CPPC_LIB [=y]
Type : bool
Defined at drivers/acpi/Kconfig:268
Depends on: ACPI [=y] && ACPI_PROCESSOR [=y]
Selects: MAILBOX [=y] && PCC [=y]
Selected by [y]:
- X86_AMD_PSTATE [=y] && CPU_FREQ [=y] && X86 [=y] && X86_64 [=y] && ACPI [=y]
Selected by [n]:
- X86_INTEL_PSTATE [=n] && CPU_FREQ [=y] && X86 [=y] && X86_64 [=y] && ACPI [=y] && SCHED_MC_PRIO [=n]
- ACPI_CPPC_CPUFREQ [=n] && CPU_FREQ [=y] && (ARM || ARM64) && ACPI_PROCESSOR [=y]
Did I miss anything?
Thanks,
Ray
next prev parent reply other threads:[~2021-11-09 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 11:55 [PATCH] Allow selecting amd-pstate without CPU_SUP_INTEL Stefano Picascia
2021-11-08 9:13 ` Huang Rui
2021-11-08 10:01 ` Stefano Picascia
2021-11-09 14:19 ` Huang Rui [this message]
2021-11-10 9:12 ` Stefano Picascia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYqDhaXDIqJyjGjg@hr-amd \
--to=ray.huang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.picascia@insiberia.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).