Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udevadm trigger --type=devices --action=add pollutes kernel log #14906

Closed
ErwanAliasr1 opened this issue Feb 19, 2020 · 7 comments
Closed

udevadm trigger --type=devices --action=add pollutes kernel log #14906

ErwanAliasr1 opened this issue Feb 19, 2020 · 7 comments

Comments

@ErwanAliasr1
Copy link

Version
Seen on systemd 219-67 but still exist in master

Used distribution
Centos

Expected behaviour you didn't see
Running /usr/bin/udevadm trigger --type=devices --action=add pollutes the kernel logs.
On a Dual AMD-7702, this commands prints 256 times "kvm: disabled by bios"
An "add" event to /sys/devices/system/cpu/cpu/uevent will print this message.
As my system has CPU 256 threads, this prints 256 times that line in the logs.
That clearly pollutes the logs.

Unexpected behaviour you saw
I would expect /usr/bin/udevadm trigger to only perform the "add" on a single cpu thread, not on all of them.

Steps to reproduce the problem
Run "/usr/bin/udevadm trigger --type=devices --action=add" on a system where the virtualization extensions are off, you'll get one line per cpu thread existing on the system.

@boucman
Copy link
Contributor

boucman commented Feb 19, 2020

Is that still the case in latest release of systemd ?

@ErwanAliasr1
Copy link
Author

Just tried master and it's fixed yes.

@ErwanAliasr1
Copy link
Author

I have no idea what release fixed it then :/

@ErwanAliasr1
Copy link
Author

At least I built up to v239 and it worked nice. Earlier version didn't built and I don't want to enter this painful build process with all possible combiniations of deps.

@yuwata
Copy link
Member

yuwata commented Feb 19, 2020

Closing then.

@yuwata yuwata closed this as completed Feb 19, 2020
@ErwanAliasr1
Copy link
Author

Got a patch merged into the kernel to reduce the noise when hit by this issue: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef935c25fd648a17c27af5d1738b1884f78c5b75

@superm1
Copy link
Contributor

superm1 commented Jun 1, 2022

With kernel 5.18.0 and systemd 249.11 (Packaged as part of Ubuntu 22.04; distro package version 249.11-0ubuntu3.1), I'm still seeing this issue happening.
I actually sent up a patch to change it to pr_err_once and was pointed at this bug report.
I can readily reproduce the problem with udevadm trigger --type=devices --action=add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants