Reporting Issues
Bug 3008 - SEV-ES fixes, updates and cleanups
Summary: SEV-ES fixes, updates and cleanups
Status: RESOLVED FIXED
Alias: None
Product: EDK2
Classification: Unclassified
Component: Code (show other bugs)
Version: Current
Hardware: All All
: Lowest normal
Assignee: thomas.lendacky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-15 09:21 UTC by thomas.lendacky
Modified: 2020-11-10 14:27 UTC (History)
2 users (show)

See Also:
EDK II Code First industry standard specifications: ---
Branch URL:
Release(s) the issue is observed:
The OS the target platform is running: ---
Package: OvmfPkg
Release(s) the issues must be fixed:
Tianocore documents:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description thomas.lendacky 2020-10-15 09:21:39 UTC
Resolve some issues and cleanup some of the code in the SEV-ES support. Specifically:
  - Cleanup GHCB offset calculations and savearea fields
  - Set the ValidBitmap fields for the SwExitCode/SwExitInfo1/SwExitInfo2/SwScratch fields when used
  - Fix Qemu flash services block erasing to use VmgExit for SEV-ES guests
  - Use GetProcessorNumber () in place of APIC ID to assign the SEV-ES reset stack
Comment 1 Laszlo Ersek 2020-10-15 12:23:19 UTC
v1 patch set on the list:

[edk2-devel] [PATCH 0/9] SEV-ES guest support fixes and cleanup
https://edk2.groups.io/g/devel/message/66099
http://mid.mail-archive.com/cover.1602346027.git.thomas.lendacky@amd.com
Comment 2 thomas.lendacky 2020-10-16 12:22:31 UTC
v2:

[PATCH v2 00/11] SEV-ES guest support fixes and cleanup
https://edk2.groups.io/g/devel/message/66327

(can't find the mail-archive.com link...)
Comment 3 Laszlo Ersek 2020-10-19 09:26:05 UTC
The mail-archive.com link becomes valid only later (once mail-archive.com indexes the new message); however, knowing the message-id of the blurb (which git-send-email does tell you), you can pre-generate the link, even before the link works. Just take the message-id, remove the angle brackets, and prefix

  http://mid.mail-archive.com/

In this case:

  http://mid.mail-archive.com/cover.1602864557.git.thomas.lendacky@amd.com

mail-archive.com is great because it lets you generate a stable and permanent URL from information you have immediately (the message-id, from git-send-email) even before the archive digests the new message. It's common that a mail-archive.com link like above starts working only one or two days after it's pasted into a bugzilla comment.
Comment 4 Laszlo Ersek 2020-10-19 09:28:48 UTC
... in other words, if you paste just the message-id from the git-send-email output, for the blurb, into the BZ, that's sufficient info.
Comment 5 thomas.lendacky 2020-10-29 11:34:07 UTC
v3:
  [edk2-devel] [PATCH v3 00/11] SEV-ES guest support fixes and cleanup
  https://edk2.groups.io/g/devel/message/66741
  http://mid.mail-archive.com/cover.1603981082.git.thomas.lendacky@amd.com
Comment 6 thomas.lendacky 2020-11-06 13:01:03 UTC
v4:
  [PATCH v4 00/11] SEV-ES guest support fixes and cleanup
  https://edk2.groups.io/g/devel/message/67099
  http://mid.mail-archive.com/cover.1604685192.git.thomas.lendacky@amd.com
Comment 7 thomas.lendacky 2020-11-06 13:05:30 UTC
By the way, I've been adding a link to mid.mail-archive.com in this bugzilla for each version of the series, but from what I can see, that site's last edk2-devel post is from October 6th.
Comment 8 Laszlo Ersek 2020-11-10 06:55:42 UTC
(In reply to thomas.lendacky from comment #7)
> By the way, I've been adding a link to mid.mail-archive.com in this bugzilla
> for each version of the series, but from what I can see, that site's last
> edk2-devel post is from October 6th.

Correct, unfortunately. I've noticed the same with some other messages that I attempted to create links for.

I contacted the Mail-Archive Support Team, the Groups.io Support Team, and the other stewards about this, on Nov 4th.

FWIW, there's yet another mailing list archive, at <https://www.redhat.com/archives/edk2-devel-archive/>. But it doesn't support message-id-based search, alas.
Comment 9 Laszlo Ersek 2020-11-10 06:56:41 UTC
So one alternate link to the v4 posting is:

https://www.redhat.com/archives/edk2-devel-archive/2020-November/msg00258.html
Comment 10 Laszlo Ersek 2020-11-10 14:27:32 UTC
(In reply to thomas.lendacky from comment #6)
> v4:
>   [PATCH v4 00/11] SEV-ES guest support fixes and cleanup
>   https://edk2.groups.io/g/devel/message/67099
>   http://mid.mail-archive.com/cover.1604685192.git.thomas.lendacky@amd.com

Merged as commit range 8c610e6075f2..d150439b7263, via <https://github.com/tianocore/edk2/pull/1110>.